Bump wasip3 to v0.4#790
Conversation
| runner = 'node' | ||
|
|
||
| [resolver] | ||
| incompatible-rust-versions = "allow" |
There was a problem hiding this comment.
wasip3 v0.4 requires Rust 1.87. Technically, we should bump rust-version for getrandom as well, but I guess it's fine to skip it in this case.
Unfortunately, this setting may complicate MSRV testing since we could pull dependencies into Cargo.lock which require a higher Rust version. I think the right way to handle this would be to execute cargo update in each MSRV job.
There was a problem hiding this comment.
Is it not sufficient to use cargo update --ignore-rust-version only in the relevant tests?
There was a problem hiding this comment.
Yes, it could work as well. But I think we should commit latest dependency versions into Cargo.lock and test with them by default, not MSRV-compatible ones. Plus, we have more non-MSRV jobs.
There was a problem hiding this comment.
See
getrandom/.github/workflows/tests.yml
Lines 373 to 376 in b229df2
| # wasi_p2_3 | ||
| [target.'cfg(all(target_arch = "wasm32", target_os = "wasi", target_env = "p3"))'.dependencies] | ||
| wasip3 = { version = "0.3", default-features = false } | ||
| wasip3 = "0.4" |
There was a problem hiding this comment.
I wonder if the MSRV issue could be worked around by depending on wasip3 = ">= 0.3, <= 0.4" (or whatever) so that 0.3 could be used to satisfy the MSRV constraint?
| - name: Generate MSRV-compatible Cargo.lock | ||
| env: | ||
| CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS: "fallback" | ||
| run: cargo update |
There was a problem hiding this comment.
IMO it would be better to restrict this to -p wasip2 -p wasip3 or whatever, instead of updating all the dependencies.
3 participants
No description provided.